-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: batch processor, aligning with latest spec changes for environments variables #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
OlivierAlbertini and
vmarchaud
as code owners
February 9, 2021 16:56
The name of the PR is not a great description of the changes. Since it is how the changelog is generated I think we should have descriptive names. |
obecny
changed the title
chore: fixes for batch processor, environments variables and the way it works
chore: batch processor, aligning with latest spec changes for environments variables
Feb 9, 2021
Codecov Report
@@ Coverage Diff @@
## main #1918 +/- ##
==========================================
- Coverage 92.78% 92.51% -0.28%
==========================================
Files 182 178 -4
Lines 6366 6063 -303
Branches 1342 1291 -51
==========================================
- Hits 5907 5609 -298
+ Misses 459 454 -5 |
dyladan
reviewed
Feb 9, 2021
MSNev
approved these changes
Feb 12, 2021
dyladan
approved these changes
Feb 12, 2021
vmarchaud
approved these changes
Feb 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes