Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove config from BasicTracerProvider#getTracer #1908

Merged

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Feb 5, 2021

Api doesn't allow to pass a tracer config to getTracer.
Also ProxyTracer and ProxyTracerProvider don't forward config.

It seems it's better to remove this option from BasicTracerProvider to avoid confusions.

Api doesn't allow to pass a tracer config to getTracer.
Also ProxyTracer and ProxyTracerProvider don't forward config.

It seems it's better to remove this option from BasicTracerProvider
to avoid confusions.
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #1908 (4c72a91) into main (70a128f) will decrease coverage by 0.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1908      +/-   ##
==========================================
- Coverage   92.77%   92.43%   -0.34%     
==========================================
  Files         172      155      -17     
  Lines        5966     5037     -929     
  Branches     1269     1071     -198     
==========================================
- Hits         5535     4656     -879     
+ Misses        431      381      -50     
Impacted Files Coverage Δ
...s/opentelemetry-tracing/src/BasicTracerProvider.ts 79.48% <100.00%> (-0.52%) ⬇️
...kages/opentelemetry-web/src/StackContextManager.ts
...mentation-xml-http-request/src/enums/EventNames.ts
...emetry-instrumentation-xml-http-request/src/xhr.ts
...s/opentelemetry-instrumentation-fetch/src/fetch.ts
packages/opentelemetry-web/src/utils.ts
packages/opentelemetry-web/src/types.ts
...kages/opentelemetry-exporter-collector/src/util.ts
...rumentation/src/platform/browser/old/autoLoader.ts
...-instrumentation-fetch/src/enums/AttributeNames.ts
... and 9 more

@dyladan dyladan merged commit dc38495 into open-telemetry:main Feb 8, 2021
@dyladan dyladan deleted the rm-gettracer-config branch February 8, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants