-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: export API singleton types #1864
Merged
dyladan
merged 5 commits into
open-telemetry:main
from
dynatrace-oss-contrib:export-api-type
Jan 27, 2021
Merged
chore: export API singleton types #1864
dyladan
merged 5 commits into
open-telemetry:main
from
dynatrace-oss-contrib:export-api-type
Jan 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
January 25, 2021 16:44
Codecov Report
@@ Coverage Diff @@
## main #1864 +/- ##
==========================================
- Coverage 92.37% 92.35% -0.02%
==========================================
Files 157 157
Lines 5104 5104
Branches 1085 1085
==========================================
- Hits 4715 4714 -1
- Misses 389 390 +1
|
vmarchaud
approved these changes
Jan 25, 2021
Flarna
approved these changes
Jan 25, 2021
Closed
Closed
@obecny ptal before merge because this affects API |
obecny
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the currently-failing lint workflow.
An update to typedoc means that only classes which are exported are included in the documentation. Here, the API singletons are exported as type only. This means they can't be used directly, but are included in the typedoc documentation and the following code will compile successfully:
The following code will still fail: