chore: remove ordered attribute dropping #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
dyladan
force-pushed
the
no-order-limits
branch
from
75672cb
to
f71a988
Compare
Codecov Report
@@ Coverage Diff @@
## master #1685 +/- ##
==========================================
- Coverage 92.13% 92.13% -0.01%
==========================================
Files 166 166
Lines 5592 5591 -1
Branches 1193 1194 +1
==========================================
- Hits 5152 5151 -1
Misses 440 440
|
mwear
approved these changes
Nov 25, 2020
obecny
approved these changes
Dec 10, 2020
|
@dyladan pls update and fix the build - I can't trigger update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In open-telemetry/opentelemetry-specification#1212 the requirement to order attributes was dropped. The current specification simply states that if the maximum number of attributes is met, then additional attributes are dropped.