feat(semantic-conventions): messaging specifications #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirsky
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1684 +/- ##
==========================================
- Coverage 92.15% 92.14% -0.02%
==========================================
Files 166 166
Lines 5573 5573
Branches 1194 1194
==========================================
- Hits 5136 5135 -1
- Misses 437 438 +1
|
naseemkullah
approved these changes
Nov 18, 2020
dyladan
approved these changes
Nov 18, 2020
obecny
reviewed
Nov 18, 2020
There was a problem hiding this comment.
One error,
What about Operation names (send, receive, process) ?
packages/opentelemetry-semantic-conventions/src/trace/messaging.ts
Outdated
Show resolved
Hide resolved
…g.ts Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>
|
@obecny added operation names and fixed the typo. |
|
Please update the branch or make the branch writeable by maintainers |
|
@dyladan Done. I don't have the "allow edit by maintainers" option due to my organization settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding messaging specifications to semantic-conventions package, as described here.