Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http keep-alive in collector exporter #1661

Merged
merged 8 commits into from
Dec 14, 2020

Conversation

srikanthccv
Copy link
Member

Fixes #1638

@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #1661 (bfe4788) into master (d113742) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1661      +/-   ##
==========================================
+ Coverage   92.17%   92.18%   +0.01%     
==========================================
  Files         167      167              
  Lines        5594     5594              
  Branches     1191     1191              
==========================================
+ Hits         5156     5157       +1     
+ Misses        438      437       -1     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a couple of questions, but otherwise this looks to be on track. Perhaps others can chime in with opinions.

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a test that verify that it correctly re-use connections

@dyladan
Copy link
Member

dyladan commented Nov 18, 2020

I haven't seen any updates since the last round of code reviews. Is this still in progress?

@srikanthccv
Copy link
Member Author

@dyladan I have made progress on this. I am having a little confusion with platform specific and package wise codebase. I am also looking about adding tests for this.

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls resolve the conflicts so we can merge it, thx

@obecny obecny added the enhancement New feature or request label Dec 14, 2020
@srikanthccv
Copy link
Member Author

pls resolve the conflicts so we can merge it, thx

@obecny Resolved. There one test failing in node12 : Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.. I think this is not related to changes from this PR.

@obecny obecny merged commit e70a7c8 into open-telemetry:master Dec 14, 2020
@srikanthccv srikanthccv deleted the keep-alive branch December 14, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use http keep-alive for OTLP/HTTP
6 participants