fix: correlation-context header #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asafb26
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1579 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 158 158
Lines 4911 4911
Branches 992 992
=======================================
Hits 4567 4567
Misses 344 344
|
dyladan
approved these changes
Oct 7, 2020
mwear
approved these changes
Oct 8, 2020
vmarchaud
approved these changes
Oct 8, 2020
obecny
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
The specs changed and removed the custom header name definition (see open-telemetry/opentelemetry-specification#993)
The w3 definition of the correlations key is now Baggage (https://w3c.github.io/baggage/#header-name)
This PR changed the name of the header only, we need to change also the CorrelationContext definitions to Baggage