feat: enable dns instrumentation by default #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naseemkullah
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
|
This should be followed up by a duplicate README change in the contrib repo. |
naseemkullah
changed the title
also updates README to reflect the change, while adding links to hapi and koa instrumentation that were missing
naseemkullah
force-pushed
the
enable-dns
branch
from
889bb33
to
9834d8f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1543 +/- ##
==========================================
+ Coverage 92.72% 93.82% +1.09%
==========================================
Files 66 154 +88
Lines 1733 4762 +3029
Branches 360 951 +591
==========================================
+ Hits 1607 4468 +2861
- Misses 126 294 +168
|
vmarchaud
approved these changes
Sep 19, 2020
dyladan
approved these changes
Sep 21, 2020
markwolff
approved these changes
Sep 21, 2020
mayurkale22
approved these changes
Sep 22, 2020
obecny
approved these changes
Sep 22, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…try#1543) chore: fix typo in test description Noticed ECS on Fargate is missing some cloud resource attributes. Comparing similar implementations like the Go ECS detector (https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/5fff1040a2844d4d435359b8108202317762593d/processor/resourcedetectionprocessor/internal/aws/ecs/ecs.go#L69); they determine these missing values based on the metadata. This implements them in a similar fashion. Co-authored-by: Haddas Bronfman <85441461+haddasbronfman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
dnsto the list of enabled plugins