Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename HttpText to TextMap propagator #1458

Merged
merged 5 commits into from
Aug 25, 2020

Conversation

dengliming
Copy link
Member

Which problem is this PR solving?

closes #1454

Short description of the changes

Rename HttpText to TextMap propagator

@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #1458 into master will increase coverage by 0.02%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master    #1458      +/-   ##
==========================================
+ Coverage   93.76%   93.78%   +0.02%     
==========================================
  Files         149      149              
  Lines        4525     4524       -1     
  Branches      939      939              
==========================================
  Hits         4243     4243              
+ Misses        282      281       -1     
Impacted Files Coverage Δ
packages/opentelemetry-api/src/api/global-utils.ts 100.00% <ø> (ø)
packages/opentelemetry-api/src/api/propagation.ts 57.57% <75.00%> (+1.69%) ⬆️
...i/src/context/propagation/NoopTextMapPropagator.ts 83.33% <100.00%> (ø)
...metry-core/src/context/propagation/B3Propagator.ts 100.00% <100.00%> (ø)
...y-core/src/context/propagation/HttpTraceContext.ts 100.00% <100.00%> (ø)
...elemetry-core/src/context/propagation/composite.ts 100.00% <100.00%> (ø)
...tion-context/propagation/HttpCorrelationContext.ts 98.03% <100.00%> (ø)
packages/opentelemetry-sdk-node/src/sdk.ts 83.05% <100.00%> (ø)

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dyladan dyladan merged commit d8bff27 into open-telemetry:master Aug 25, 2020
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename HTTPText to TextMap Propagator
5 participants