Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(exporter-collector): CollectorTransportNode should be CollectorProtocolNode #1432

Merged
merged 2 commits into from
Aug 20, 2020
Merged

docs(exporter-collector): CollectorTransportNode should be CollectorProtocolNode #1432

merged 2 commits into from
Aug 20, 2020

Conversation

hongbo-miao
Copy link
Contributor

@hongbo-miao hongbo-miao commented Aug 16, 2020 •
edited
Loading

Which problem is this PR solving?

  • The API in the doc is wrong.

Short description of the changes

  • When I try to use latest @opentelemetry/exporter-collector version 0.10.2, I believe the current correct API is CollectorProtocolNode instead of CollectorTransportNode.

If you search CollectorTransportNode in the source code of this repo, there is no such thing actually.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 16, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Aug 16, 2020 •
edited
Loading

Codecov Report

Merging #1432 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1432   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files         148      148           
  Lines        4393     4393           
  Branches      894      894           
=======================================
  Hits         4125     4125           
  Misses        268      268

@hongbo-miao hongbo-miao changed the title docs(exporter-collector): change CollectorTransportNode to CollectorProtocolNode docs(exporter-collector): CollectorTransportNode should be CollectorProtocolNode Aug 18, 2020
@dyladan dyladan added the document Documentation-related label Aug 20, 2020
@dyladan dyladan merged commit a3357d5 into open-telemetry:master Aug 20, 2020
@hongbo-miao hongbo-miao deleted the patch-1 branch August 20, 2020 18:09
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@unflxw
fix(pg): do not replace argument with plain object (open-telemetry#1432)
e691537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@markwolff markwolff markwolff approved these changes

@dyladan dyladan dyladan approved these changes

@legendecas legendecas Awaiting requested review from legendecas

@mwear mwear Awaiting requested review from mwear

@naseemkullah naseemkullah Awaiting requested review from naseemkullah

@obecny obecny Awaiting requested review from obecny

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

@vmarchaud vmarchaud Awaiting requested review from vmarchaud

Assignees
No one assigned
Labels
document Documentation-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hongbo-miao @dyladan @markwolff @mayurkale22