Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opentelemetry-web): capture decodedBodySize / http.response_content_length #1262

Merged
merged 11 commits into from
Jul 6, 2020

Conversation

johnbley
Copy link
Member

@johnbley johnbley commented Jun 30, 2020

Capture encodedBodySize from PerformanceResourceTiming (when available); report as http.response_content_length.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 30, 2020

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #1262 into master will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1262      +/-   ##
==========================================
+ Coverage   92.86%   93.09%   +0.22%     
==========================================
  Files         126      133       +7     
  Lines        3364     3764     +400     
  Branches      688      761      +73     
==========================================
+ Hits         3124     3504     +380     
- Misses        240      260      +20     
Impacted Files Coverage Δ
...entelemetry-semantic-conventions/src/trace/http.ts 0.00% <ø> (ø)
packages/opentelemetry-web/src/types.ts 100.00% <ø> (ø)
...telemetry-plugin-fetch/src/enums/AttributeNames.ts 100.00% <100.00%> (ø)
...ntelemetry-web/src/enums/PerformanceTimingNames.ts 100.00% <100.00%> (ø)
packages/opentelemetry-web/src/utils.ts 94.59% <100.00%> (+0.11%) ⬆️
...ry-plugin-xml-http-request/src/enums/EventNames.ts 100.00% <0.00%> (ø)
...kages/opentelemetry-exporter-collector/src/util.ts 100.00% <0.00%> (ø)
...porter-collector/src/CollectorTraceExporterBase.ts 94.87% <0.00%> (ø)
...ages/opentelemetry-exporter-collector/src/types.ts 100.00% <0.00%> (ø)
.../opentelemetry-exporter-collector/src/transform.ts 96.34% <0.00%> (ø)
... and 2 more

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My my concern is naming.
With regards to the size itself there are also decodedBodySize and encodedBodySize. Having that in mind should we create another issue to add those too deciding about suitable name from
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/http.md#common-attributes

@johnbley johnbley changed the title feat(opentelemetry-web): capture transferSize feat(opentelemetry-web): capture encodedBodySize / http.response_content_length Jul 2, 2020
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dyladan dyladan added the enhancement New feature or request label Jul 6, 2020
@dyladan dyladan merged commit 85c430a into open-telemetry:master Jul 6, 2020
@dyladan dyladan changed the title feat(opentelemetry-web): capture encodedBodySize / http.response_content_length feat(opentelemetry-web): capture decodedBodySize / http.response_content_length Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants