-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(opentelemetry-web): capture decodedBodySize / http.response_content_length #1262
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #1262 +/- ##
==========================================
+ Coverage 92.86% 93.09% +0.22%
==========================================
Files 126 133 +7
Lines 3364 3764 +400
Branches 688 761 +73
==========================================
+ Hits 3124 3504 +380
- Misses 240 260 +20
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My my concern is naming.
With regards to the size itself there are also decodedBodySize
and encodedBodySize
. Having that in mind should we create another issue to add those too deciding about suitable name from
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/http.md#common-attributes
packages/opentelemetry-plugin-xml-http-request/test/xhr.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-plugin-fetch/src/enums/AttributeNames.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Capture
encodedBodySize
from PerformanceResourceTiming (when available); report ashttp.response_content_length
.