Remove @rochdev from @open-telemetry/js-approvers #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
dyladan,
legendecas,
markwolff,
mwear,
naseemkullah,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
dyladan
approved these changes
Jun 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #1257 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 126 126
Lines 3597 3597
Branches 724 724
=======================================
Hits 3356 3356
Misses 241 241 |
obecny
approved these changes
Jun 29, 2020
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on offline discussion with @rochdev.
(apparently) Roch is very eager to resume the contribution soon, but for now we have decided to remove him from the approvers list.
Many thanks to @rochdev for your contributions and valuable reviews on the many PRs at early stage.