Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node-plugins-all package #1181

Merged
merged 9 commits into from
Jun 17, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jun 10, 2020

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #1181 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1181   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         122      122           
  Lines        3533     3533           
  Branches      714      714           
=======================================
  Hits         3262     3262           
  Misses        271      271           

Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayurkale22 mayurkale22 added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Jun 13, 2020
metapackages/plugins-node-all/package.json Outdated Show resolved Hide resolved
@dyladan dyladan requested a review from legendecas as a code owner June 17, 2020 17:32
@dyladan dyladan merged commit a2d1964 into open-telemetry:master Jun 17, 2020
@dyladan dyladan added the enhancement New feature or request label Jun 17, 2020
@dyladan dyladan deleted the plugins-all branch June 17, 2020 18:11
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* added another block to test for v2

* feat: changing export name to reflect generic docker

* feat: adding geenric naming and logic changes to support cgroup v2

* test: test file renamed

* feat: adding hostname check

* feat: adding hostname check- refactor

* feat: fixed a test and fixed lint

* feat: added another condition to check for length

* test: added two more tests

* feat: renamed docker to container and addressed pr comments

* feat: renamed docker to container and addressed pr comments- 2

* feat: renamed docker to container and addressed pr comments-3

* feat: addressed pr comments-2

* feat: modified tests to take in multiple lines input

* feat: merge resolution for manifest

* feat: fixing release please manifest

* feat: changing please-config to rename docker to container

* feat: replaced >= check to == check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants