Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename meaure to value recorder #1117

Merged
merged 5 commits into from
Jun 2, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 27, 2020

Fixes #1112

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a quick question on a first pass, was there any documentation or examples that needs to be updated as well ?

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #1117 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1117   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         116      116           
  Lines        3396     3396           
  Branches      686      686           
=======================================
  Hits         3134     3134           
  Misses        262      262           
Impacted Files Coverage Δ
packages/opentelemetry-api/src/metrics/Metric.ts 100.00% <ø> (ø)
packages/opentelemetry-metrics/src/types.ts 100.00% <ø> (ø)
...ackages/opentelemetry-api/src/metrics/NoopMeter.ts 73.17% <100.00%> (ø)
...kages/opentelemetry-metrics/src/BoundInstrument.ts 100.00% <100.00%> (ø)
packages/opentelemetry-metrics/src/Meter.ts 96.29% <100.00%> (ø)
packages/opentelemetry-metrics/src/Metric.ts 100.00% <100.00%> (ø)
...ckages/opentelemetry-metrics/src/export/Batcher.ts 100.00% <100.00%> (ø)
...trics/src/export/aggregators/ValueRecorderExact.ts 100.00% <100.00%> (ø)
...ntelemetry-metrics/src/export/aggregators/index.ts 100.00% <100.00%> (ø)
packages/opentelemetry-metrics/src/export/types.ts 100.00% <100.00%> (ø)

@dyladan
Copy link
Member Author

dyladan commented May 27, 2020

just a quick question on a first pass, was there any documentation or examples that needs to be updated as well ?

I'm sure there is, but this touches enough places that I am going to do it as separate PRs so it isn't overwhelming to review.

@mayurkale22 that ok?

@mayurkale22
Copy link
Member

I'm sure there is, but this touches enough places that I am going to do it as separate PRs so it isn't overwhelming to review.

@mayurkale22 that ok?

https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-metrics#measure I think this is the only place we have a reference for Measure. I would prefer to handle that in this PR.

@dyladan
Copy link
Member Author

dyladan commented May 27, 2020

done

@dyladan dyladan added the API label May 27, 2020
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dyladan dyladan mentioned this pull request May 27, 2020
@mayurkale22
Copy link
Member

@dyladan Looks like this is good to merge now.

@dyladan dyladan merged commit b6f9d2a into open-telemetry:master Jun 2, 2020
@dyladan dyladan deleted the value-recorder branch June 2, 2020 14:31
naseemkullah pushed a commit to naseemkullah/opentelemetry-js that referenced this pull request Jun 2, 2020
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Measure to ValueRecorder
4 participants