Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(batcher): document how to configure custom aggregators #989 #1100

Merged
merged 3 commits into from
May 28, 2020

Conversation

vmarchaud
Copy link
Member

I don't think we got a specific folder where we document how to extend the SDK to customise its behavior so i've wrote it inside the doc the folder, happy to move it if you think this is more of an example !

closes #989

@vmarchaud vmarchaud added the document Documentation-related label May 23, 2020
@vmarchaud vmarchaud self-assigned this May 23, 2020
@vmarchaud vmarchaud added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 23, 2020
@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #1100 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1100   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files         115      115           
  Lines        3407     3407           
  Branches      686      686           
=======================================
  Hits         3147     3147           
  Misses        260      260           

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few minor comments, otherwise LGTM

doc/batcher-api.md Outdated Show resolved Hide resolved
doc/batcher-api.md Outdated Show resolved Hide resolved
doc/batcher-api.md Outdated Show resolved Hide resolved
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mayurkale22 mayurkale22 merged commit 2987534 into open-telemetry:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to create metrics with different aggregators
3 participants