-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: format README #1065
Merged
mayurkale22
merged 2 commits into
open-telemetry:master
from
naseemkullah:format-readme
May 18, 2020
Merged
style: format README #1065
mayurkale22
merged 2 commits into
open-telemetry:master
from
naseemkullah:format-readme
May 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naseem <naseem@transit.app>
naseemkullah
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
May 16, 2020 13:50
Codecov Report
@@ Coverage Diff @@
## master #1065 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 213 213
Lines 8950 8950
Branches 806 806
=======================================
Hits 8514 8514
Misses 436 436 |
mayurkale22
approved these changes
May 16, 2020
dyladan
approved these changes
May 18, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* chore: remove node 8 and 10 from CI * chore: update engines * chore: add node 18 to CI * fix(resource-detector-alibaba-cloud): call .destroy() directly on the socket * test: reference the actual error message * test(instrumentation-fastify): check for similarity with ROOT_CONTEXT, not reference equality In the CI there will be 3 instances of the API installed(relative to the repo root): - `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/api`, - `./node_modules/@opentelemetry/api`, - `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/instrumentation-http/node_modules/@opentelemetry/api`. * chore: remove support for node@12 updating the engines * chore: remove test runs on node@12 * test(resource-detector-alibaba-cloud): revert change, disable tests for node@18 * fix: turn fastify tests off for node@18
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 13, 2024
* chore: remove node 8 and 10 from CI * chore: update engines * chore: add node 18 to CI * fix(resource-detector-alibaba-cloud): call .destroy() directly on the socket * test: reference the actual error message * test(instrumentation-fastify): check for similarity with ROOT_CONTEXT, not reference equality In the CI there will be 3 instances of the API installed(relative to the repo root): - `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/api`, - `./node_modules/@opentelemetry/api`, - `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/instrumentation-http/node_modules/@opentelemetry/api`. * chore: remove support for node@12 updating the engines * chore: remove test runs on node@12 * test(resource-detector-alibaba-cloud): revert change, disable tests for node@18 * fix: turn fastify tests off for node@18
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 16, 2024
* chore: remove node 8 and 10 from CI * chore: update engines * chore: add node 18 to CI * fix(resource-detector-alibaba-cloud): call .destroy() directly on the socket * test: reference the actual error message * test(instrumentation-fastify): check for similarity with ROOT_CONTEXT, not reference equality In the CI there will be 3 instances of the API installed(relative to the repo root): - `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/api`, - `./node_modules/@opentelemetry/api`, - `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/instrumentation-http/node_modules/@opentelemetry/api`. * chore: remove support for node@12 updating the engines * chore: remove test runs on node@12 * test(resource-detector-alibaba-cloud): revert change, disable tests for node@18 * fix: turn fastify tests off for node@18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixing up spacing. 🤷♂️
(Tables were formatted automatically. Empty lines were added/removed manually.)