Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix readme: setting labelKeys when creating the counter #1056

Merged
merged 1 commit into from
May 14, 2020
Merged

fix readme: setting labelKeys when creating the counter #1056

merged 1 commit into from
May 14, 2020

Conversation

luebken
Copy link
Contributor

@luebken luebken commented May 14, 2020

Which problem is this PR solving?

  • Readme from "OpenTelemetry Prometheus Metric Exporter" was not working

Short description of the changes

  • setting labelKeys when creating the counter
  • using pid as a nicer example for the label

@luebken luebken changed the title fix: setting labelKeys when creating the counter fix readme: setting labelKeys when creating the counter May 14, 2020
mayurkale22
mayurkale22 approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dyladan dyladan added the document Documentation-related label May 14, 2020
@mayurkale22 mayurkale22 merged commit c0aad1d into open-telemetry:master May 14, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@rauno56
feat(lru-memoizer): add instrumentation for lru-memoizer (open-teleme…
68cf014 
…try#1056)

* feat(lru-memoizer): add instrumentation for lru-memoizer

* fix(lru-memoizer): typescript issues in test

* fix(auto-instrumentation): fix tests

* chore: downgrade expect to support node 8

* chore(lru-memoizer): fix expect version

* fix(lru-memoizer): typos and rephrase

* chore(lru-memoizer): comments rephrases

* style(lru-memoizer): unified suppored versions

* style(lru-memoizer): better wording in README

* fix(lru-memoizer): check cb before binding

Co-authored-by: Rauno Viskus <Rauno56@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@dyladan dyladan dyladan approved these changes

@bg451 bg451 Awaiting requested review from bg451

@markwolff markwolff Awaiting requested review from markwolff

@obecny obecny Awaiting requested review from obecny

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

@rochdev rochdev Awaiting requested review from rochdev

@vmarchaud vmarchaud Awaiting requested review from vmarchaud

Assignees
No one assigned
Labels
document Documentation-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luebken @dyladan @mayurkale22