Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include proto files in deployment package #1053

Merged
merged 2 commits into from
May 13, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 13, 2020

Fixes #1027

@dyladan dyladan added the bug Something isn't working label May 13, 2020
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented May 13, 2020

Codecov Report

Merging #1053 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1053   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files         213      213           
  Lines        8950     8950           
  Branches      806      806           
=======================================
  Hits         8514     8514           
  Misses        436      436           

@dyladan dyladan merged commit e83174f into open-telemetry:master May 13, 2020
@dyladan dyladan deleted the include-proto branch May 13, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: collector-exported v0.7.0 doesnt contains proto
5 participants