Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric names are case sensitive #4057

Closed
dyladan opened this issue Aug 11, 2023 · 2 comments · Fixed by #4059
Closed

Metric names are case sensitive #4057

dyladan opened this issue Aug 11, 2023 · 2 comments · Fixed by #4059
Labels
bug Something isn't working priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect

Comments

@dyladan
Copy link
Member

dyladan commented Aug 11, 2023

The specification states that metric names are case insensitive. If we see a metric which is the same except for name-case, they are the same metric stream and should be exported as a single stream with the first encountered name. Currently we treat them as separate streams.

What would the guidance be for SDKs like JS that already made a different choice? Should we coalesce on the new behavior as a bug fix and just accept that it is breaking, or should we flag this for 2.0?

edit: to be clear, we didn't make this choice consciously. we simply missed it while building the metric sdk

I see this as a bug fix.

First off, there shouldn't be any public interfaces or functions that change from this. Only the export behavior.

Specifically for the duplicate stream case: the duplicate instrument registration section already specifies that identical instruments need to aggregated into a single data stream:

Originally posted by @MrAlias in open-telemetry/opentelemetry-specification#3539 (comment)

@dyladan dyladan added bug Something isn't working priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect labels Aug 11, 2023
@dyladan
Copy link
Member Author

dyladan commented Aug 11, 2023

@legendecas do you have time to look into this?

@legendecas
Copy link
Member

I agree that tagging this as a bug fix is reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants