Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for process.runtime.* attributes for Node resource detector #2562

Closed
pkwarren opened this issue Oct 22, 2021 · 1 comment · Fixed by #2727
Closed

Add support for process.runtime.* attributes for Node resource detector #2562

pkwarren opened this issue Oct 22, 2021 · 1 comment · Fixed by #2727
Labels
feature-request never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@pkwarren
Copy link

Is your feature request related to a problem? Please describe.

Other languages (like Go, Java) expose useful information in traces in the process.runtime.* attributes. For example:

process.runtime.description=go version go1.17.2 linux/amd64
process.runtime.name=gc
process.runtime.version=go1.17.2

Describe the solution you'd like

Update @opentelemetry/resources package to add process.runtime.* attributes in https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-resources/src/platform/node/detectors/ProcessDetector.ts.

Describe alternatives you've considered

Setting these attributes in a custom resource detector.

Additional context

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/semantic_conventions/process.md#process-runtimes

@vmarchaud vmarchaud added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Oct 26, 2021
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants