Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-metrics]: Create or verify compliance of Async Counter #2550

Closed
Tracked by #2480
dyladan opened this issue Oct 20, 2021 · 3 comments · Fixed by #2569 or #2687
Closed
Tracked by #2480

[api-metrics]: Create or verify compliance of Async Counter #2550

dyladan opened this issue Oct 20, 2021 · 3 comments · Fixed by #2569 or #2687
Assignees

Comments

@dyladan
Copy link
Member

dyladan commented Oct 20, 2021

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#asynchronous-counter

  • Creation method
    • name (required)
    • callback (required)
    • unit (optional string)
    • description (optional string)
  • Interface
    • No methods
    • callback
      • observer argument
        • observe method
  • Noop implementation
@dyladan dyladan added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Oct 20, 2021
@legendecas
Copy link
Member

legendecas commented Oct 27, 2021

When the batch observer is available, the callback shall be optional if I understand correctly. But as the batch observer is not included in the feature freeze API spec, I have no idea whether or not we should change the API definition for now.

@dyladan
Copy link
Member Author

dyladan commented Oct 27, 2021

As of now the status seems the same as in #2548:

@dyladan
Copy link
Member Author

dyladan commented Oct 27, 2021

@legendecas batch observer was removed from the spec along with bind in order to simplify the spec for v1 so the release can go as smoothly as possible. After v1 it will be added back in afaik. For now we should remove it since we can't know what the final implementation will look like.

@dyladan dyladan removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants