Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global error handler - default handler #1591

Open
mwear opened this issue Oct 12, 2020 · 2 comments
Open

Global error handler - default handler #1591

mwear opened this issue Oct 12, 2020 · 2 comments
Labels
Discussion Issue or PR that needs/is extended discussion.

Comments

@mwear
Copy link
Member

mwear commented Oct 12, 2020

We recently added a global error handler in #1514. The default handler uses a ConsoleLogger at LogLevel.Error. This has the unfortunate side effect of spamming standard out during tests. Should we consider making the default global error handler a no-op instead?

@mwear mwear added the Discussion Issue or PR that needs/is extended discussion. label Oct 12, 2020
@obecny
Copy link
Member

obecny commented Oct 12, 2020

my 3 cents: I would be in favor of having a noop as a default.

@vmarchaud
Copy link
Member

I think it would make sense in the test suite, however i believe we need to report errors for end user by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Development

No branches or pull requests

3 participants