Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js example has missing dependency #1357

Closed
reggiemcdonald opened this issue Jul 27, 2020 · 1 comment · Fixed by #1364
Closed

grpc-js example has missing dependency #1357

reggiemcdonald opened this issue Jul 27, 2020 · 1 comment · Fixed by #1364
Assignees
Labels
bug Something isn't working

Comments

@reggiemcdonald
Copy link
Contributor

Please answer these questions before submitting a bug report.

What version of OpenTelemetry are you using?

0.9.0

What version of Node are you using?

v14.4.0

What did you do?

Ran the grpc-js example located here.

What did you expect to see?

The example should run.

What did you see instead?

An error is thrown because module grpc could not be found.

Additional context

The compiled proto files require 'grpc' which wont work because the example uses grpc-js. You can see the import here:

'use strict';
const grpc = require('grpc');
const helloworld_pb = require('./helloworld_pb.js');

The grpc team has realeased a tool to fix this issue called grpc-tools. So this problem could be resolved by recompiling the proto files with that.

Alternatively, instead of working with compiled protocol buffers, it would also work to use the proto-loader.

@reggiemcdonald reggiemcdonald added the bug Something isn't working label Jul 27, 2020
@reggiemcdonald
Copy link
Contributor Author

I can fix this if someone can assign me to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant