Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec Change: Allow injectors and extractors to be separate interfaces #1006

Closed
dyladan opened this issue Apr 30, 2020 · 2 comments
Closed

Spec Change: Allow injectors and extractors to be separate interfaces #1006

dyladan opened this issue Apr 30, 2020 · 2 comments
Labels
Discussion Issue or PR that needs/is extended discussion.

Comments

@dyladan
Copy link
Member

dyladan commented Apr 30, 2020

Link to spec PR: open-telemetry/opentelemetry-specification#578

OTEP-66 originally had the propagator interface divided into separate Injectors and Extractors. In OpenTelemetry Ruby we found some advantages to this division. For example, you can have asymmetry in the formats that are injected / extracted, and there are situations where order matters. By dividing Propagators into Injectors and Extractors you can still implement the Propagator and CompositePropagator interfaces by composing individual Injectors and Extractors. This PR updates the api-propagators spec to allow for that possibility.

@mwear would you like to take a look at this and see how it can be applied?

@mwear
Copy link
Member

mwear commented May 14, 2020

This doesn't require a change to OpenTemetry JS. It allows propagators to be split into injectors and extractors if it makes sense. You will still have a Propagator (and CompositePropagator) interface, they will just be composed of individual extractors and injectors. If this is something the SIG would like to do, the spec change allows for it, but it's not required.

@dyladan dyladan added Discussion Issue or PR that needs/is extended discussion. and removed required-by-spec labels May 15, 2020
@legendecas
Copy link
Member

Closing as the issue is no longer applicable.

@legendecas legendecas closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Development

No branches or pull requests

3 participants