fix(plugin-dns): remove from default plugin list (#613)

closes #612 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
open-telemetry · Dec 12, 2019 · 9a91434 · 9a91434
1 parent d32565a
commit 9a91434
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/packages/opentelemetry-node/src/config.ts b/packages/opentelemetry-node/src/config.ts
@@ -28,7 +28,6 @@ export interface NodeTracerConfig extends BasicTracerConfig {
 /** List of all default supported plugins */
 export const DEFAULT_INSTRUMENTATION_PLUGINS: Plugins = {
   'mongodb-core': { enabled: true, path: '@opentelemetry/plugin-mongodb-core' },
-  dns: { enabled: true, path: '@opentelemetry/plugin-dns' },
   grpc: { enabled: true, path: '@opentelemetry/plugin-grpc' },
   http: { enabled: true, path: '@opentelemetry/plugin-http' },
   https: { enabled: true, path: '@opentelemetry/plugin-https' },

diff --git a/packages/opentelemetry-plugin-dns/README.md b/packages/opentelemetry-plugin-dns/README.md
@@ -32,6 +32,23 @@ const tracer = new NodeTracer({
 });
 ```
 
+### Zipkin
+
+If you use Zipkin, you must use `ignoreHostnames` in order to not trace those calls. If the server is local. You can set :
+
+```
+const tracer = new NodeTracer({
+  plugins: {
+    dns: {
+      enabled: true,
+      // You may use a package name or absolute path to the file.
+      path: '@opentelemetry/plugin-dns',
+      ignoreHostnames: ['localhost']
+    }
+  }
+});
+```
+
 ### Dns Plugin Options
 
 Dns plugin has currently one option. You can set the following: