From 46f0dfa576c127e91177518be7ec942e44653280 Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Wed, 24 May 2023 17:17:24 +0200 Subject: [PATCH 1/7] chore(instrumentation-grpc): add 'grpc' deprecation notice postinstall script --- .../packages/opentelemetry-instrumentation-grpc/package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/experimental/packages/opentelemetry-instrumentation-grpc/package.json b/experimental/packages/opentelemetry-instrumentation-grpc/package.json index a61d995bfe2..04eb2103a1c 100644 --- a/experimental/packages/opentelemetry-instrumentation-grpc/package.json +++ b/experimental/packages/opentelemetry-instrumentation-grpc/package.json @@ -18,7 +18,8 @@ "watch": "tsc --build --watch", "precompile": "lerna run version --scope $(npm pkg get name) --include-dependencies", "prewatch": "node ../../../scripts/version-update.js", - "peer-api-check": "node ../../../scripts/peer-api-check.js" + "peer-api-check": "node ../../../scripts/peer-api-check.js", + "postinstall": "node -e \"console.log(\\\"@opentelemetry/instrumentation-grpc - warning: The package 'grpc' (https://www.npmjs.com/package/grpc) is deprecated, support for telemetry generation will be dropped in the next release. Please migrate to '@grpc/grpc-js' (https://www.npmjs.com/package/@grpc/grpc-js) to continue receiving telemetry.\\\");\"" }, "keywords": [ "opentelemetry", From c4ce5e7db425d962a3b5b7e8ea007675dd6abcb6 Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Wed, 24 May 2023 17:20:06 +0200 Subject: [PATCH 2/7] chore(instrumentation-grpc): add changelog --- experimental/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index 4ef6fff6190..b56a5b3dcf2 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -7,6 +7,7 @@ All notable changes to experimental packages in this project will be documented ### :boom: Breaking Change * fix(exporter-logs-otlp-grpc): change OTLPLogsExporter to OTLPLogExporter [#3819](https://github.com/open-telemetry/opentelemetry-js/pull/3819) @fuaiyi +* chore(instrumentation-grpc): add 'grpc' deprecation notice postinstall script [#tbd](https://github.com/open-telemetry/opentelemetry-js/pull/3819) @pichlermarc ### :rocket: (Enhancement) From b80a5c4b489f0dd663d6b7abb43a9ca96122f0d3 Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Wed, 24 May 2023 17:51:47 +0200 Subject: [PATCH 3/7] chore(instrumentation-grpc): add changelog pr number --- experimental/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index b56a5b3dcf2..28d6cc4c21e 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -7,7 +7,7 @@ All notable changes to experimental packages in this project will be documented ### :boom: Breaking Change * fix(exporter-logs-otlp-grpc): change OTLPLogsExporter to OTLPLogExporter [#3819](https://github.com/open-telemetry/opentelemetry-js/pull/3819) @fuaiyi -* chore(instrumentation-grpc): add 'grpc' deprecation notice postinstall script [#tbd](https://github.com/open-telemetry/opentelemetry-js/pull/3819) @pichlermarc +* chore(instrumentation-grpc): add 'grpc' deprecation notice postinstall script [#3833](https://github.com/open-telemetry/opentelemetry-js/pull/3833) @pichlermarc ### :rocket: (Enhancement) From 29c2aabad145903f321be1430c6dd2374b895d90 Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Wed, 24 May 2023 17:56:23 +0200 Subject: [PATCH 4/7] chore(instrumentation-grpc): add more changelog text --- experimental/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index 28d6cc4c21e..48f09660099 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -8,6 +8,8 @@ All notable changes to experimental packages in this project will be documented * fix(exporter-logs-otlp-grpc): change OTLPLogsExporter to OTLPLogExporter [#3819](https://github.com/open-telemetry/opentelemetry-js/pull/3819) @fuaiyi * chore(instrumentation-grpc): add 'grpc' deprecation notice postinstall script [#3833](https://github.com/open-telemetry/opentelemetry-js/pull/3833) @pichlermarc + * Support for telemetry generation for the [`grpc`](https://www.npmjs.com/package/grpc) module will be dropped in the next release as the package has been + deprecated for over 1 year, please migrate to [`@grpc/grpc-js`](https://www.npmjs.com/package/@grpc/grpc-js) to continue receiving telemetry. ### :rocket: (Enhancement) From 36f25a6b6fc41518bffe864ef0d5fc6af75499fb Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Thu, 25 May 2023 07:41:09 +0200 Subject: [PATCH 5/7] chore(instrumentation-grpc): add more changelog text Co-authored-by: Daniel Dyla --- .../packages/opentelemetry-instrumentation-grpc/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/experimental/packages/opentelemetry-instrumentation-grpc/package.json b/experimental/packages/opentelemetry-instrumentation-grpc/package.json index 04eb2103a1c..f37f6a666db 100644 --- a/experimental/packages/opentelemetry-instrumentation-grpc/package.json +++ b/experimental/packages/opentelemetry-instrumentation-grpc/package.json @@ -19,7 +19,7 @@ "precompile": "lerna run version --scope $(npm pkg get name) --include-dependencies", "prewatch": "node ../../../scripts/version-update.js", "peer-api-check": "node ../../../scripts/peer-api-check.js", - "postinstall": "node -e \"console.log(\\\"@opentelemetry/instrumentation-grpc - warning: The package 'grpc' (https://www.npmjs.com/package/grpc) is deprecated, support for telemetry generation will be dropped in the next release. Please migrate to '@grpc/grpc-js' (https://www.npmjs.com/package/@grpc/grpc-js) to continue receiving telemetry.\\\");\"" + "postinstall": "node -e \"console.log(\\\"@opentelemetry/instrumentation-grpc - warning: The package 'grpc' (https://www.npmjs.com/package/grpc) is deprecated. It will no longer be instrumented in the next release. Please migrate to '@grpc/grpc-js' (https://www.npmjs.com/package/@grpc/grpc-js) to continue receiving telemetry.\\\");\"" }, "keywords": [ "opentelemetry", From af8b4f03636bb724605fc345228a0720a6a1f6f2 Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Thu, 25 May 2023 16:29:06 +0200 Subject: [PATCH 6/7] chore(instrumentation-grpc): clarify logged text Co-authored-by: Daniel Dyla --- .../packages/opentelemetry-instrumentation-grpc/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/experimental/packages/opentelemetry-instrumentation-grpc/package.json b/experimental/packages/opentelemetry-instrumentation-grpc/package.json index f37f6a666db..8a23d16fbb7 100644 --- a/experimental/packages/opentelemetry-instrumentation-grpc/package.json +++ b/experimental/packages/opentelemetry-instrumentation-grpc/package.json @@ -19,7 +19,7 @@ "precompile": "lerna run version --scope $(npm pkg get name) --include-dependencies", "prewatch": "node ../../../scripts/version-update.js", "peer-api-check": "node ../../../scripts/peer-api-check.js", - "postinstall": "node -e \"console.log(\\\"@opentelemetry/instrumentation-grpc - warning: The package 'grpc' (https://www.npmjs.com/package/grpc) is deprecated. It will no longer be instrumented in the next release. Please migrate to '@grpc/grpc-js' (https://www.npmjs.com/package/@grpc/grpc-js) to continue receiving telemetry.\\\");\"" + "postinstall": "node -e \"console.log(\\\"@opentelemetry/instrumentation-grpc - warning: The package 'grpc' (https://www.npmjs.com/package/grpc) is deprecated. It will no longer be instrumented in the next release of '@opentelemetry/instrumentation-grpc'. Please migrate to '@grpc/grpc-js' (https://www.npmjs.com/package/@grpc/grpc-js) to continue receiving telemetry.\\\");\"" }, "keywords": [ "opentelemetry", From 18ad5e5a960e0e7230d3556b42acef15a73c2c00 Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Fri, 26 May 2023 06:48:18 +0200 Subject: [PATCH 7/7] chore(instrumentation-grpc): add color --- .../packages/opentelemetry-instrumentation-grpc/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/experimental/packages/opentelemetry-instrumentation-grpc/package.json b/experimental/packages/opentelemetry-instrumentation-grpc/package.json index 8a23d16fbb7..1e63a6dd062 100644 --- a/experimental/packages/opentelemetry-instrumentation-grpc/package.json +++ b/experimental/packages/opentelemetry-instrumentation-grpc/package.json @@ -19,7 +19,7 @@ "precompile": "lerna run version --scope $(npm pkg get name) --include-dependencies", "prewatch": "node ../../../scripts/version-update.js", "peer-api-check": "node ../../../scripts/peer-api-check.js", - "postinstall": "node -e \"console.log(\\\"@opentelemetry/instrumentation-grpc - warning: The package 'grpc' (https://www.npmjs.com/package/grpc) is deprecated. It will no longer be instrumented in the next release of '@opentelemetry/instrumentation-grpc'. Please migrate to '@grpc/grpc-js' (https://www.npmjs.com/package/@grpc/grpc-js) to continue receiving telemetry.\\\");\"" + "postinstall": "node -e \"console.log(\\\"\\x1b[95m%s\\x1b[0m\\\", \\\"@opentelemetry/instrumentation-grpc - warning: The package 'grpc' (https://www.npmjs.com/package/grpc) is deprecated. It will no longer be instrumented in the next release of '@opentelemetry/instrumentation-grpc'. Please migrate to '@grpc/grpc-js' (https://www.npmjs.com/package/@grpc/grpc-js) to continue receiving telemetry.\\\");\"" }, "keywords": [ "opentelemetry",