Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 0.21.0 release proposal #536

Merged
merged 2 commits into from
Jun 16, 2021
Merged

chore: 0.21.0 release proposal #536

merged 2 commits into from
Jun 16, 2021

Conversation

github-actions[bot]
Copy link
Contributor

This is an auto-generated release PR. If additional changes need to be incorporated before the release, the CHANGELOG must be updated manually.

Merging this PR will automatically release all packages to NPM.

@github-actions github-actions bot requested a review from a team June 14, 2021 19:25
@vmarchaud

This comment has been minimized.

@vmarchaud vmarchaud requested a review from a team June 14, 2021 19:36
@Flarna
Copy link
Member

Flarna commented Jun 15, 2021

Not directly related to thi PR. Once again it seems we miss updating examples. e.g. express is still refering to 0.15.0.
Maybe we should simply remove them as there is no CI testing them nor is there someone having the time to keep them up and running. I guess it's quite a bad experience for users to start with non working examples.

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #536 (c6077cf) into main (3ea5298) will increase coverage by 0.05%.
The diff coverage is 40.00%.

❗ Current head c6077cf differs from pull request most recent head a49796c. Consider uploading reports for the commit a49796c to get more accurate results

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   94.82%   94.88%   +0.05%     
==========================================
  Files         157      162       +5     
  Lines        9862     9986     +124     
  Branches      957      986      +29     
==========================================
+ Hits         9352     9475     +123     
- Misses        510      511       +1     
Impacted Files Coverage Δ
...ntelemetry-resource-detector-github/src/version.ts 0.00% <0.00%> (ø)
...apackages/auto-instrumentations-web/src/version.ts 0.00% <0.00%> (ø)
...opentelemetry-id-generator-aws-xray/src/version.ts 0.00% <0.00%> (ø)
...s/opentelemetry-propagator-aws-xray/src/version.ts 0.00% <0.00%> (ø)
...metry-propagator-grpc-census-binary/src/version.ts 0.00% <0.00%> (ø)
...s/opentelemetry-propagator-ot-trace/src/version.ts 0.00% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/version.ts 100.00% <100.00%> (ø)
...entelemetry-instrumentation-graphql/src/version.ts 100.00% <100.00%> (ø)
...de/opentelemetry-instrumentation-pg/src/version.ts 100.00% <100.00%> (ø)
...web/opentelemetry-plugin-react-load/src/version.ts 100.00% <100.00%> (ø)
... and 5 more

@vmarchaud
Copy link
Member

Once again it seems we miss updating examples

This is a long standing issue for every release, we have few issues opened for adding examples in lerna so dependencies are bumped for each release. A part from that, we'll need to re-release a new version thats compatible with 1.0 of the API so i think updating manually examples can wait a little more.

@dyladan
Copy link
Member

dyladan commented Jun 16, 2021

Not directly related to thi PR. Once again it seems we miss updating examples. e.g. express is still refering to 0.15.0.
Maybe we should simply remove them as there is no CI testing them nor is there someone having the time to keep them up and running. I guess it's quite a bad experience for users to start with non working examples.

These are generated automatically now. There's no way to really update the examples automatically since it likely requires code changes.

@vmarchaud vmarchaud merged commit 621f014 into main Jun 16, 2021
@vmarchaud vmarchaud deleted the release/0.21.0 branch June 16, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants