-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update core to 0.20.0 #513
chore: update core to 0.20.0 #513
Conversation
Codecov Report
@@ Coverage Diff @@
## main #513 +/- ##
==========================================
+ Coverage 95.36% 95.37% +0.01%
==========================================
Files 147 147
Lines 8930 8974 +44
Branches 873 897 +24
==========================================
+ Hits 8516 8559 +43
- Misses 414 415 +1
|
plugins/node/opentelemetry-instrumentation-winston/src/winston.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-bunyan/src/bunyan.ts
Outdated
Show resolved
Hide resolved
Might be helpful to ignore white space on review since the linter made some changes to indents |
@@ -1,7 +1,7 @@ | |||
{ | |||
"name": "restify-example", | |||
"private": true, | |||
"version": "0.18.0", | |||
"version": "0.15.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the history of this file -- the first version was checked in as 0.18.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most likely core was 18 at that time and the original contributor was confused what our policy is?
Thank you much! |
Still waiting on #520 for release but things are looking like it should be done in the next few minutes |
This is the minimum updates to take advantage of the latest API. It does not take advantage of new features like startActiveSpan