Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update core to 0.20.0 #513

Merged
merged 5 commits into from
Jun 4, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jun 3, 2021

This is the minimum updates to take advantage of the latest API. It does not take advantage of new features like startActiveSpan

@dyladan dyladan requested a review from a team June 3, 2021 19:55
@dyladan dyladan added depencies enhancement New feature or request labels Jun 3, 2021
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #513 (c4d73cd) into main (7ca20f8) will increase coverage by 0.01%.
The diff coverage is 99.02%.

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   95.36%   95.37%   +0.01%     
==========================================
  Files         147      147              
  Lines        8930     8974      +44     
  Branches      873      897      +24     
==========================================
+ Hits         8516     8559      +43     
- Misses        414      415       +1     
Impacted Files Coverage Δ
...lugin-react-load/src/BaseOpenTelemetryComponent.ts 97.02% <80.00%> (-0.48%) ⬇️
...try-instrumentation-graphql/src/instrumentation.ts 92.30% <100.00%> (ø)
...opentelemetry-instrumentation-graphql/src/utils.ts 95.26% <100.00%> (ø)
...metry-instrumentation-graphql/test/graphql.test.ts 100.00% <100.00%> (ø)
...elemetry-instrumentation-pg/src/instrumentation.ts 82.29% <100.00%> (ø)
...ntelemetry-instrumentation-pg/test/pg-pool.test.ts 89.51% <100.00%> (ø)
...e/opentelemetry-instrumentation-pg/test/pg.test.ts 94.42% <100.00%> (ø)
...metry-propagator-aws-xray/src/AWSXRayPropagator.ts 100.00% <100.00%> (ø)
...propagator-aws-xray/test/AWSXRayPropagator.test.ts 100.00% <100.00%> (ø)
...tor-grpc-census-binary/src/GrpcCensusPropagator.ts 97.43% <100.00%> (ø)
... and 18 more

examples/express/package.json Outdated Show resolved Hide resolved
examples/hapi/package.json Outdated Show resolved Hide resolved
examples/koa/package.json Outdated Show resolved Hide resolved
examples/network/package.json Outdated Show resolved Hide resolved
examples/react-load/preact/package.json Show resolved Hide resolved
examples/redis/package.json Outdated Show resolved Hide resolved
@dyladan
Copy link
Member Author

dyladan commented Jun 3, 2021

Might be helpful to ignore white space on review since the linter made some changes to indents

@@ -1,7 +1,7 @@
{
"name": "restify-example",
"private": true,
"version": "0.18.0",
"version": "0.15.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the history of this file -- the first version was checked in as 0.18.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely core was 18 at that time and the original contributor was confused what our policy is?

@dyladan dyladan merged commit 6c2378c into open-telemetry:main Jun 4, 2021
@dyladan dyladan deleted the update-core-20 branch June 4, 2021 12:05
@lizthegrey
Copy link
Member

Thank you much!

@dyladan
Copy link
Member Author

dyladan commented Jun 4, 2021

Still waiting on #520 for release but things are looking like it should be done in the next few minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants