-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add x-ray id generator #423
Conversation
Codecov Report
@@ Coverage Diff @@
## main #423 +/- ##
==========================================
+ Coverage 95.83% 96.11% +0.28%
==========================================
Files 15 21 +6
Lines 624 695 +71
Branches 94 95 +1
==========================================
+ Hits 598 668 +70
- Misses 26 27 +1
|
Apologies for churn on browser tests - locally I get this weird error which I haven't been able to debug yet so scrambling in the dark a bit
|
Might be useful to try setting |
packages/opentelemetry-id-generator-aws-xray/test/AWSXrayIdGenerator.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-id-generator-aws-xray/test/AWSXrayIdGenerator.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-id-generator-aws-xray/src/platform/node/AWSXRayIdGenerator.ts
Show resolved
Hide resolved
packages/opentelemetry-id-generator-aws-xray/src/platform/node/AWSXRayIdGenerator.ts
Show resolved
Hide resolved
…trib into xray-idgenerator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Flarna for the review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you have some error on browsers tests, can you please check if it works fine on karma v.4 instead of 5 ?
"karma-coverage-istanbul-reporter": "3.0.3", | ||
"karma-mocha": "2.0.1", | ||
"karma-spec-reporter": "0.0.32", | ||
"karma-webpack": "5.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this working for you as karma 5 doesn't work for me (osx), had to downgrade back to 4
@obecny Thanks - with karma 4 I get less error output, just |
Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>
@dyladan would be awesome if this could be merged with its approvals :) |
Which problem is this PR solving?
Short description of the changes