Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 0.15.0 release proposal #409

Merged
merged 2 commits into from
Apr 5, 2021
Merged

chore: 0.15.0 release proposal #409

merged 2 commits into from
Apr 5, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 1, 2021

This is an auto-generated release PR. If additional changes need to be incorporated before the release, the CHANGELOG must be updated manually.

Merging this PR will automatically release all packages to NPM.

@github-actions github-actions bot requested a review from a team April 1, 2021 20:28
@obecny
Copy link
Member

obecny commented Apr 1, 2021

missing otel dependencies being updated to latest in propagators, examples, metapackages (auto), detectors
it wasn't updated here -> #408

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@Flarna
Copy link
Member

Flarna commented Apr 1, 2021

Some PRs are missing in the changelog: #386, #338, #394, #351

@dyladan
Copy link
Member

dyladan commented Apr 1, 2021

Those PRs were missing labels. I'll update the changelog.

@dyladan
Copy link
Member

dyladan commented Apr 5, 2021

missing otel dependencies being updated to latest in propagators, examples, metapackages (auto), detectors
it wasn't updated here -> #408

It was just a patch update so the examples shouldn't be affected. Only reason it needed to be done in #408 was to ensure dependency resolution didn't get messed up

Also, the dependencies use the ^ range which means they should get the latest patch versions anyway.

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #409 (e7eb898) into main (55fa0e9) will decrease coverage by 0.21%.
The diff coverage is 33.33%.

❗ Current head e7eb898 differs from pull request most recent head ee7cdf9. Consider uploading reports for the commit ee7cdf9 to get more accurate results

@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
- Coverage   94.43%   94.21%   -0.22%     
==========================================
  Files          11       12       +1     
  Lines         431      432       +1     
  Branches       48       48              
==========================================
  Hits          407      407              
- Misses         24       25       +1     
Impacted Files Coverage Δ
...apackages/auto-instrumentations-web/src/version.ts 0.00% <0.00%> (ø)
...s/opentelemetry-propagator-ot-trace/src/version.ts 0.00% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/version.ts 100.00% <100.00%> (ø)

@dyladan
Copy link
Member

dyladan commented Apr 5, 2021

Changelog fixed. @obecny I don't think the examples need to be updated since they are ^ range dependencies so they should get the latest anyway. In any case the release PR should probably be kept only to things pertaining to release. Other version changes can be done in another PR if needed.

@obecny
Copy link
Member

obecny commented Apr 5, 2021

Changelog fixed. @obecny I don't think the examples need to be updated since they are ^ range dependencies so they should get the latest anyway. In any case the release PR should probably be kept only to things pertaining to release. Other version changes can be done in another PR if needed.

Can we endup with having mixed version of api 0.18, 0.18.1 and rc, and because people will be able to use version 0.18.0, 0.18.1 and 0.18.2 of core plugins where 0.18.1 is broken ?

@dyladan
Copy link
Member

dyladan commented Apr 5, 2021

Changelog fixed. @obecny I don't think the examples need to be updated since they are ^ range dependencies so they should get the latest anyway. In any case the release PR should probably be kept only to things pertaining to release. Other version changes can be done in another PR if needed.

Can we endup with having mixed version of api 0.18, 0.18.1 and rc, and because people will be able to use version 0.18.0, 0.18.1 and 0.18.2 of core plugins where 0.18.1 is broken ?

Everything that uses the ^ version range will receive the latest matching version which is 0.18.2. If they installed a pinned 0.18.1 somewhere it would be broken, but they should not have some dependencies pinned and others not.

@dyladan dyladan merged commit a2de775 into main Apr 5, 2021
@dyladan dyladan deleted the release/0.15.0 branch April 5, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants