Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mysql instrumentation #393

Merged
merged 7 commits into from
Mar 23, 2021
Merged

feat: mysql instrumentation #393

merged 7 commits into from
Mar 23, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Mar 22, 2021

This contains no functionality changes aside from what it took to do the conversion and pass tests.

@dyladan dyladan added the enhancement New feature or request label Mar 22, 2021
@dyladan dyladan requested a review from a team March 22, 2021 20:07
@codecov
Copy link

codecov bot commented Mar 22, 2021 •
edited
Loading

Codecov Report

Merging #393 (f269ba4) into main (ddba154) will not change coverage.
The diff coverage is n/a.

❗ Current head f269ba4 differs from pull request most recent head 758241f. Consider uploading reports for the commit 758241f to get more accurate results

@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files          10       10           
  Lines         407      407           
  Branches       44       44           
=======================================
  Hits          384      384           
  Misses         23       23

@obecny
Copy link
Member

obecny commented Mar 22, 2021

don't merge yet there are more broken links

@vmarchaud
Copy link
Member

vmarchaud commented Mar 23, 2021 •
edited
Loading

don't merge yet there are more broken links

You mean in the PR ? I don't see any

Also @dyladan i can't rebase your PR so you'll need to do it

@obecny
Copy link
Member

obecny commented Mar 23, 2021

don't merge yet there are more broken links

You mean in the PR ? I don't see any

Also @dyladan i can't rebase your PR so you'll need to do it

Ignore it, I posted it in wrong PR :/

obecny
obecny reviewed Mar 23, 2021
View reviewed changes
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you uncomment mysql in meta package ?

@dyladan
Copy link
Member Author

dyladan commented Mar 23, 2021

can you uncomment mysql in meta package ?

done

@dyladan dyladan merged commit 5ba4a48 into open-telemetry:main Mar 23, 2021
@dyladan dyladan deleted the instrumentation-mysql branch March 23, 2021 14:29
@dyladan dyladan mentioned this pull request Mar 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@obecny obecny obecny approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dyladan @obecny @vmarchaud @Flarna