-
Notifications
You must be signed in to change notification settings - Fork 592
refactor: use isWrapped from instrumentation package #2704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use isWrapped from instrumentation package #2704
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2704 +/- ##
=======================================
Coverage 92.40% 92.40%
=======================================
Files 171 171
Lines 8142 8142
Branches 1647 1647
=======================================
Hits 7524 7524
Misses 618 618
|
Hrm, this should have failed
|
Ah, Likely from a merge: that PR and adding lint:deps were both within days of each other. |
#2709 added to fix that up. |
Which problem is this PR solving?
For
@opentelemetry/core@2.0.0
we'll removeisWrapped()
since it's duplicated in@opentelemetry/instrumentation
. It makes more sense to have it in@opentelemetry/instrumentation
since that's actually an instrumentation-related utility function.Refs open-telemetry/opentelemetry-js#5444
Short description of the changes
Uses
isWrapped()
from@opentelemetry/instrumentation
instead. It is a drop-in replacement as the implementations are identical:ShimWrapped
is also fully compatible: