Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.10.0 proposal #199

Merged
merged 21 commits into from
Sep 9, 2020
Merged

v0.10.0 proposal #199

merged 21 commits into from
Sep 9, 2020

Conversation

obecny
Copy link
Member

@obecny obecny commented Sep 7, 2020

  1. Upgraded core packages to 0.11.0
  2. Fixes after upgrade
  3. Added lerna changelog in package.json to support plugin_request label
  4. Renamed package plugins-node-all to plugins-node-core-and-contrib

Draft Release: https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/untagged-4839a22120767d5485a8

@obecny obecny requested a review from a team September 7, 2020 18:00
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #199 into master will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   95.21%   95.21%   -0.01%     
==========================================
  Files          92       92              
  Lines        4724     4723       -1     
  Branches      488      488              
==========================================
- Hits         4498     4497       -1     
  Misses        226      226              
Impacted Files Coverage Δ
...lugin-react-load/src/BaseOpenTelemetryComponent.ts 97.46% <ø> (-0.02%) ⬇️
...metry-propagator-grpc-census-binary/src/version.ts 0.00% <0.00%> (ø)
...s/node/opentelemetry-plugin-pg-pool/src/version.ts 100.00% <100.00%> (ø)
...lugins/node/opentelemetry-plugin-pg/src/version.ts 100.00% <100.00%> (ø)
...web/opentelemetry-plugin-react-load/src/version.ts 100.00% <100.00%> (ø)

@obecny obecny merged commit 6430737 into open-telemetry:master Sep 9, 2020
@michaelgoin
Copy link
Contributor

@dyladan looks like the node-plugins-all package was renamed as a part of this PR... as such, should I still do a rename of that package only to the "instrumentation" convention like we discussed before OR should I just roll that in with the full rename of everything?

Originally, I was going to do that first to fix the versioning issues per our discussions in the meeting. Seems like that probably is no-longer needed?

@obecny obecny deleted the 0.10.0-proposal branch October 28, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants