-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add knex support for 1.x.x and 2.x.x #861
Labels
Comments
1 task
blumamir
changed the title
knex instrumentation report support for >= 0.22.0 but tests fails for v1.0.0
knex instrumentation claims support for >= 0.22.0 but tests fails for v1.0.0
Jan 30, 2022
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
blumamir
changed the title
knex instrumentation claims support for >= 0.22.0 but tests fails for v1.0.0
add knex support for 1.x.x and 2.x.x
Apr 22, 2022
There is version 2 as of 21/04/2022.
|
1 task
dyladan
added
enhancement
New feature or request
and removed
bug
Something isn't working
labels
Sep 14, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of OpenTelemetry are you using?
latest (0.27.1)
What version of Node are you using?
14
What did you do?
Knex instrumentation supports versions >= 0.22.0
Knex published version 1.0.0 on 16/01/2022.
When renovate tried to update the version in this PR, tests failed for v1:
and more.
I don't know if it's only the tests, or the instrumentation itself should be updated, but we should examine this and add test-all-versions.
cc @rauno56
The text was updated successfully, but these errors were encountered: