-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Baggage span processor - key predicate #2166
Comments
MikeGoldsmith
changed the title
Baggage span processor key predicate
Baggage span processor - key predicate
Apr 29, 2024
This was referenced Apr 29, 2024
Adding here the comment from the PR, that changing the default behaviour for baggage key collection in the future to a "safe one" will probably be a breaking change for this component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Enhancement idea to the Baggage Span Processor to allow configuration of a user-provided key predicate function used to determine whether a baggage entry should be added to newly started spans.
Wondering if you considered as an alternative adding a config option that can filter out attributes for collection. Perhaps some function that receives an attribute name and return if it should be recorder or not?
and then users can opt-in to collect only attributes they know are safe, or specifically feed a function that returns
true
to record everything?This can shift the responsibility of what is being collected to the user, allowing safe flexibility in collection without introducing breaking changes in the future.
Originally posted by @blumamir in #2114 (comment)
The text was updated successfully, but these errors were encountered: