FastifyDeprecation: Request#context property access is deprecated. Please use "Request#routeConfig" or "Request#routeSchema" instead for accessing Route settings. The "Request#context" will be removed in fastify@5.

[stefee]

What version of OpenTelemetry are you using?

@opentelemetry/instrumentation-fastify@0.30.1

What version of Node are you using?

v16.14.2

What did you do?

Node auto instrumentation on a Fastify application

What did you expect to see?

No deprecation notices

What did you see instead?

FastifyDeprecation: Request#context property access is deprecated. Please use "Request#routeConfig" or "Request#routeSchema" instead for accessing Route settings. The "Request#context" will be removed in `fastify@5`.

Additional context

Request .context is used here:

opentelemetry-js-contrib/plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts

Line 262 in aff84bb

const requestContext = (request as any).context || {};

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[stefee]

Bump

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[SimenB]

PR is incoming in fastify: fastify/fastify#4470

[Bruno-DaSilva]

bump :(

[Uzlopak]

To fix the issue in opentelemetry, you would need to patch

opentelemetry-js-contrib/plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts

Line 263 in 154b30b

const requestContext = (request as any).context || {};

There I think you would need to change it to:

      const handlerName = (((request as any).routeConfig || {})?.name || '').substr(6);

[Uzlopak]

Or maybe even simpler:

      const handlerName = (request as any)?.routeConfig?.name?.substr(6) || '';

I did not test it.

[freakyfelt]

Alas that one won't work as the routeConfig does not expose the handler, so we're waiting for fastify/fastify#4470

[Uzlopak]

I closed the remaining issues in the fastify PR and requested review by @Eomm

[drewcorlin1]

Wouldn't this be the most type safe way to fix the warning?

const handlerName = `${request.routeOptions.method} ${request.routeOptions.url}`;

[freakyfelt]

Wouldn't this be the most type safe way to fix the warning?

This particular label is for the name of the handler (e.g. the name of the function), so changing it would be a breaking a change

[SimenB]

Change in Fastify landed now (:tada:), so once that's released it's hopefully not too difficult to migrate the instrumentation.

This particular label is for the name of the handler (e.g. the name of the function), so changing it would be a breaking a change

The instrumentation is experimental (v0.x), so I don't think that's a huge concern? Not sure how these things are managed.

[Travispersson]

Change in Fastify landed now (🎉), so once that's released it's hopefully not too difficult to migrate the instrumentation.

This particular label is for the name of the handler (e.g. the name of the function), so changing it would be a breaking a change

The instrumentation is experimental (v0.x), so I don't think that's a huge concern? Not sure how these things are managed.

It's now available in the latest Fastify release that was released today 🥳

[Travispersson]

Hmm, just a note, I'm getting these deprecation warnings as well from this instrumentation lib

[FSTDEP017] FastifyDeprecation: You are accessing the deprecated "request.routerPath" property. Use "request.routeOptions.url" instead. Property "req.routerPath" will be removed in `fastify@5`.

Could be this line?

opentelemetry-js-contrib/plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts

Line 272 in b10224b

[SemanticAttributes.HTTP_ROUTE]: request.routerPath,

edit: I see that the PR linked to this issue is addressing that though, nice! 💯

[Uzlopak]

yes

[mateus4k]

[FSTDEP017] FastifyDeprecation: You are accessing the deprecated "request.routerPath" property. Use "request.routeOptions.url" instead. Property "req.routerPath" will be removed in `fastify@5`.

Is there any PR updating this?

[Travispersson]

[FSTDEP017] FastifyDeprecation: You are accessing the deprecated "request.routerPath" property. Use "request.routeOptions.url" instead. Property "req.routerPath" will be removed in `fastify@5`.

Is there any PR updating this?

#1679
Yep a fix was released ⭐

[mateus4k]

Thanks, @Travispersson!

[omBratteng]

Still getting this error

(node:9) [FSTDEP017] FastifyDeprecation: You are accessing the deprecated "request.routerPath" property. Use "request.routeOptions.url" instead. Property "req.routerPath" will be removed in `fastify@5`.

We are using the latest version of the intrumentation

https://github.com/dailydotdev/daily-api/blob/dc3bbecd7c04984a60a224b19ae9752102caf09e/package.json#L48

and version 4.24.2 of fastify

https://github.com/dailydotdev/daily-api/blob/dc3bbecd7c04984a60a224b19ae9752102caf09e/package.json#L71

[omBratteng]

So digging a bit further into it, I think it might when the requests are to not found pages. but then both request.routeOptions.url and request.routerPath are undefined.

[Wazbat]

I can confirm that I'm also still getting these errors

(node:1) [FSTDEP017] FastifyDeprecation: You are accessing the deprecated "request.routerPath" property. Use "request.routeOptions.url" instead. Property "req.routerPath" will be removed in `fastify@5`.

fastify 4.24.3 and @opentelemetry/instrumentation-fastify 0.32.3

[SimenB]

That's separate from the one in the OP (which hss been fixed, from what I can tell). Might be worth its own issue? Or just somebody sending a PR 🙂

[omBratteng]

I've split it into a separate issue here #1757

[trentm]

I believe this was fixed in #1679, when one is using fastify >=4.23.0 (when the request.routeOptions.handler option was made available). When using earlier fastify versions there is nothing the instrumentation can do to avoid the deprecation warning.

I have a PR up for the separate #1757 issue.

[trentm]

I believe this was fixed in #1679,

^ @pichlermarc I think you can close this issue.