Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OT Bridge: Decide whether to activate DistContext/TagMap or not #546

Closed
carlosalberto opened this issue Sep 19, 2019 · 1 comment
Closed
Labels
priority:p2 Medium priority issues and bugs. release:required-for-ga Required for 1.0 GA release

Comments

@carlosalberto
Copy link
Contributor

OpenTracing's SpanContext contains Baggage, which is backed up internally by an instance of DistributedContext (previously called TagMap), which works seamlessly underneath.

One thing to decide is whether we want to also set this aforementioned DistributedContext object as active when its 'parent' Span is set as the active instance:

try (Scope scope = io.opentracing.Tracer.activate(Span)) {
  // The wrapped io.opentelemetry.trace.Span *is* set active
  // The wrapped io.opentelemetry.distributedcontext.DistributedContext **is not**
}

There are a few possible challenges here, such as doing the deactivate/activate step of DistributedContext when the Baggage changes from the OT Bridge side, while keeping other components in the proper activation stack order (either other Span/DistributedContext objects).

@jkwatson jkwatson added the release:required-for-ga Required for 1.0 GA release label Jul 21, 2020
@jkwatson jkwatson added the priority:p2 Medium priority issues and bugs. label Aug 12, 2020
@jkwatson jkwatson modified the milestone: 1.0 Jan 15, 2021
@carlosalberto
Copy link
Contributor Author

Closed on behalf of #3049 as the discussed changes are already covered by the aforementioned issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p2 Medium priority issues and bugs. release:required-for-ga Required for 1.0 GA release
Projects
None yet
Development

No branches or pull requests

2 participants