Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTracing Shim: Align Shim Layer creation arguments #4909

Closed
Tracked by #4911
carlosalberto opened this issue Nov 2, 2022 · 0 comments · Fixed by #4988
Closed
Tracked by #4911

OpenTracing Shim: Align Shim Layer creation arguments #4909

carlosalberto opened this issue Nov 2, 2022 · 0 comments · Fixed by #4988

Comments

@carlosalberto
Copy link
Contributor

Per the spec, we need to support creation of the Shim layer with an overload taking TracerProvider AND Propagators. We already have an overload taking an OpenTelemetry object, which implicitly satisfies this, but we should add the mentioned overload for completeness reasons.

See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/opentracing.md#create-an-opentracing-tracer-shim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add missing createTracerShim function cuichenli/opentelemetry-java
1 participant
@carlosalberto