Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update exponential histogram to use upper-inclusive boundaries #4698

Closed
jmacd opened this issue Aug 18, 2022 · 2 comments · Fixed by #4700
Closed

Update exponential histogram to use upper-inclusive boundaries #4698

jmacd opened this issue Aug 18, 2022 · 2 comments · Fixed by #4700
Assignees
@jack-berg
Labels
Bug Something isn't working metrics

Comments

@jmacd
Copy link

jmacd commented Aug 18, 2022

Describe the request

Specification PR open-telemetry/opentelemetry-specification#2633 has changed the boundary conditions for exponential histograms and specified that SDKs SHOULD be exact for powers-of-two. This implies a fairly complex change, see open-telemetry/opentelemetry-go#2982 for example.
@jmacd jmacd added Bug Something isn't working metrics labels Aug 18, 2022
@jack-berg jack-berg self-assigned this Aug 18, 2022
@jack-berg
Copy link
Member

I've been working on this! Will have a PR sometime today.

@jack-berg jack-berg mentioned this issue Aug 18, 2022
Merged
@jack-berg
Copy link
Member

FYI, the corresponding change to the proto definition has yet to be merged / released. Despite this, I think its ok for us to proceed with this change beforehand given the experimental status of our exponential histograms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jack-berg jack-berg

Labels
Bug Something isn't working metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lower exclusive exponential histogram bounds jack-berg/opentelemetry-java
2 participants
@jmacd @jack-berg