Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ProbabilitySampler to TraceIdRatioBasedSampler #1573

Closed
jkwatson opened this issue Aug 21, 2020 · 5 comments · Fixed by #1666
Closed

Rename ProbabilitySampler to TraceIdRatioBasedSampler #1573

jkwatson opened this issue Aug 21, 2020 · 5 comments · Fixed by #1666
Assignees
@dengliming @akshay1312
Labels
good first issue help wanted priority:p2 Medium priority issues and bugs. release:required-for-ga Required for 1.0 GA release

Comments

@jkwatson
Copy link
Contributor

Also verify we're meeting the spec after this merge:
open-telemetry/opentelemetry-specification#611
@jkwatson jkwatson added help wanted release:required-for-ga Required for 1.0 GA release priority:p2 Medium priority issues and bugs. labels Aug 21, 2020
@dengliming
Copy link
Member

We should rename this at opentelemetry-proto repo (open-telemetry/opentelemetry-proto#212) at the same time.

@akshay1312
Copy link

i can pick this to work on.

@carlosalberto
Copy link
Contributor

Hey @akshay1312 still working on this?

@dengliming
Copy link
Member

I am willing to take this If no one has started yet.

@dengliming
Copy link
Member

I have submitted a related PR here

This was referenced Sep 18, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dengliming dengliming

@akshay1312 akshay1312

Labels
good first issue help wanted priority:p2 Medium priority issues and bugs. release:required-for-ga Required for 1.0 GA release
Projects
None yet
Milestone
No milestone
4 participants
@carlosalberto @jkwatson @dengliming @akshay1312