Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage BatchSpanProcessor's span dropping functionality #1566

Closed
huntc opened this issue Aug 20, 2020 · 0 comments · Fixed by #1579
Closed

Leverage BatchSpanProcessor's span dropping functionality #1566

huntc opened this issue Aug 20, 2020 · 0 comments · Fixed by #1579
Assignees
@anuraaga @huntc @iNikem
Labels
Bug Something isn't working priority:p1 Critical issues and bugs. Highest priority; breaking API changes. release:required-for-ga Required for 1.0 GA release

Comments

@huntc
Copy link
Contributor

huntc commented Aug 20, 2020

The recent change to make the export methods async appears to have introduced a situation where the BatchSpanProcessor can lose telemetry in the case where its spansList isn't drained fast enough.

While the BatchSpanProcessor is built to cater for spans being dropped, and therefore its usage must assume this as a possibility, we can at least ensure that exportBatches is replaced by a function to take just one batch (drainBatch?) so that the existing BatchSpanProcessor reporting of dropped telemetry is leveraged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anuraaga anuraaga

@huntc huntc

@iNikem iNikem

Labels
Bug Something isn't working priority:p1 Critical issues and bugs. Highest priority; breaking API changes. release:required-for-ga Required for 1.0 GA release
Projects
None yet
Milestone
No milestone
4 participants
@anuraaga @huntc @jkwatson @iNikem