From 199df3a25ca624f36b045c1b15c9ce7b3c0dc6af Mon Sep 17 00:00:00 2001 From: Carlos Alberto Cortez Date: Fri, 31 Jul 2020 04:43:28 +0200 Subject: [PATCH] Do simple logging for failed export. (#1480) * Simple logging for failed export. * Use WARNING instead of SEVERE. --- .../opentelemetry/exporters/jaeger/JaegerGrpcSpanExporter.java | 1 + .../io/opentelemetry/exporters/otlp/OtlpGrpcMetricExporter.java | 1 + .../io/opentelemetry/exporters/otlp/OtlpGrpcSpanExporter.java | 1 + .../io/opentelemetry/exporters/zipkin/ZipkinSpanExporter.java | 1 + 4 files changed, 4 insertions(+) diff --git a/exporters/jaeger/src/main/java/io/opentelemetry/exporters/jaeger/JaegerGrpcSpanExporter.java b/exporters/jaeger/src/main/java/io/opentelemetry/exporters/jaeger/JaegerGrpcSpanExporter.java index 2062fa75fbe..9d6d3bd47a1 100644 --- a/exporters/jaeger/src/main/java/io/opentelemetry/exporters/jaeger/JaegerGrpcSpanExporter.java +++ b/exporters/jaeger/src/main/java/io/opentelemetry/exporters/jaeger/JaegerGrpcSpanExporter.java @@ -126,6 +126,7 @@ public ResultCode export(Collection spans) { stub.postSpans(request); return ResultCode.SUCCESS; } catch (Throwable e) { + logger.log(Level.WARNING, "Failed to export spans", e); return ResultCode.FAILURE; } } diff --git a/exporters/otlp/src/main/java/io/opentelemetry/exporters/otlp/OtlpGrpcMetricExporter.java b/exporters/otlp/src/main/java/io/opentelemetry/exporters/otlp/OtlpGrpcMetricExporter.java index 762c8f999d7..5b2d9982e80 100644 --- a/exporters/otlp/src/main/java/io/opentelemetry/exporters/otlp/OtlpGrpcMetricExporter.java +++ b/exporters/otlp/src/main/java/io/opentelemetry/exporters/otlp/OtlpGrpcMetricExporter.java @@ -103,6 +103,7 @@ public ResultCode export(Collection metrics) { stub.export(exportMetricsServiceRequest); return ResultCode.SUCCESS; } catch (Throwable e) { + logger.log(Level.WARNING, "Failed to export metrics", e); return ResultCode.FAILURE; } } diff --git a/exporters/otlp/src/main/java/io/opentelemetry/exporters/otlp/OtlpGrpcSpanExporter.java b/exporters/otlp/src/main/java/io/opentelemetry/exporters/otlp/OtlpGrpcSpanExporter.java index 5282dff674c..f7bcb07d79c 100644 --- a/exporters/otlp/src/main/java/io/opentelemetry/exporters/otlp/OtlpGrpcSpanExporter.java +++ b/exporters/otlp/src/main/java/io/opentelemetry/exporters/otlp/OtlpGrpcSpanExporter.java @@ -111,6 +111,7 @@ public ResultCode export(Collection spans) { stub.export(exportTraceServiceRequest); return ResultCode.SUCCESS; } catch (Throwable e) { + logger.log(Level.WARNING, "Failed to export spans", e); return ResultCode.FAILURE; } } diff --git a/exporters/zipkin/src/main/java/io/opentelemetry/exporters/zipkin/ZipkinSpanExporter.java b/exporters/zipkin/src/main/java/io/opentelemetry/exporters/zipkin/ZipkinSpanExporter.java index 35035aa27ec..edc373d7b86 100644 --- a/exporters/zipkin/src/main/java/io/opentelemetry/exporters/zipkin/ZipkinSpanExporter.java +++ b/exporters/zipkin/src/main/java/io/opentelemetry/exporters/zipkin/ZipkinSpanExporter.java @@ -246,6 +246,7 @@ public ResultCode export(final Collection spanDataList) { try { sender.sendSpans(encodedSpans).execute(); } catch (Exception e) { + logger.log(Level.WARNING, "Failed to export spans", e); return ResultCode.FAILURE; } return ResultCode.SUCCESS;