From 0bed21f142c71512cfe422240d6c267706e83c84 Mon Sep 17 00:00:00 2001 From: Bogdan Drutu Date: Tue, 13 Jun 2023 09:31:56 -0700 Subject: [PATCH] Make Advice proper immutable class Signed-off-by: Bogdan Drutu --- .../sdk/metrics/internal/descriptor/Advice.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/descriptor/Advice.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/descriptor/Advice.java index d88ab7359e6..f2da8a4090c 100644 --- a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/descriptor/Advice.java +++ b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/descriptor/Advice.java @@ -6,6 +6,8 @@ package io.opentelemetry.sdk.metrics.internal.descriptor; import com.google.auto.value.AutoValue; +import java.util.ArrayList; +import java.util.Collections; import java.util.List; import javax.annotation.Nullable; import javax.annotation.concurrent.Immutable; @@ -21,6 +23,10 @@ public static Advice empty() { } public static Advice create(@Nullable List explicitBucketBoundaries) { + if (explicitBucketBoundaries != null) { + explicitBucketBoundaries = + Collections.unmodifiableList(new ArrayList<>(explicitBucketBoundaries)); + } return new AutoValue_Advice(explicitBucketBoundaries); }