Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark HttpRouteBiGetter vs capturing lambda to make sure it's needed #5215

Open
trask opened this issue Jan 25, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@trask
Copy link
Member

trask commented Jan 25, 2022

This was introduced in #4014 (and renamed in #5211).

It was introduced (along with the single arg variant) in order to avoid memory allocation via capturing lambdas.

It's called at each step in servlet filter chains, so is potentially a useful optimization, but we should benchmark to make sure that the alternative (capturing lambda) doesn't get JIT optimized via escape analysis and perform equally well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant