Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Android API-friendliness checks to library instrumentation #3913

Closed
3 tasks
jkwatson opened this issue Aug 23, 2021 · 1 comment · Fixed by #4505
Closed
3 tasks

Add Android API-friendliness checks to library instrumentation #3913

jkwatson opened this issue Aug 23, 2021 · 1 comment · Fixed by #4505
Labels
enhancement New feature or request

Comments

@jkwatson
Copy link
Contributor

jkwatson commented Aug 23, 2021 •
edited by trask
Loading

For library instrumentation that we expect to work on Android, we should add some build-time checks to make sure we're not adding java 8 features that aren't supported on Android 21+.

  • OkHttp3 3.x
  • gRPC
  • Apache HTTP Client 4.3
@jkwatson jkwatson added the enhancement New feature or request label Aug 23, 2021
@mateuszrzeszutek
Copy link
Member

We should also add those checks to instrumentation-api (and instrumentation-api-caching, if it needs a separate one)

@mateuszrzeszutek mateuszrzeszutek mentioned this issue Oct 26, 2021
Merged
@bherbst bherbst mentioned this issue Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Android API-friendliness checks mateuszrzeszutek/opentelemetry-java-instrumentation
2 participants
@jkwatson @mateuszrzeszutek