Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document available configuration #342

Open
iNikem opened this issue Apr 23, 2020 · 10 comments
Open

Document available configuration #342

iNikem opened this issue Apr 23, 2020 · 10 comments
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@iNikem
Copy link
Contributor

iNikem commented Apr 23, 2020

I was unable to find any documentation about supported configuration options. io.opentelemetry.auto.config.Config class has quite a lot of options that can be of interest to end-users.

@trask trask added good first issue Good for newcomers contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome labels Apr 25, 2020
@trask trask added documentation Improvements or additions to documentation and removed good first issue Good for newcomers labels May 6, 2020
@mnottheone
Copy link

mnottheone commented Jul 10, 2020

We need these docs about config parameters. My understanding is 1255 and 479 has been released in 0.4.0. Docs doesn't reflect these parameters.

Below should set sampler probability to 0.2

java -javaagent:path/to/opentelemetry-auto-all.jar -Dota.exporter=zipkin -Dotel.config.sampler.probability=0.2 -jar myapp.jar

If yes, should we update the docs?

@iNikem
Copy link
Contributor Author

iNikem commented Jul 10, 2020

Of course we should update the docs. This issue is exactly about that :) Do you care to submit a PR and kick it off?

@trask
Copy link
Member

trask commented Jul 12, 2020

I split out a more targeted issue specifically to document the standard OpenTelemetry env var / system properties that we support #666.

@breedx-splk
Copy link
Contributor

#666 has been closed for a while, and I feel like the docs are pretty good at this point. Is there any more to do on this one?

@iNikem
Copy link
Contributor Author

iNikem commented Dec 16, 2020

@breedx-splk We don't have any documentation for instrumentation-specific configurations like otel.instrumentation.kafka.client-propagation

@trask trask added this to the v1.0 milestone Jan 27, 2021
@trask trask removed this from the v1.0 milestone Jun 11, 2021
@vasireddy99
Copy link
Contributor

Just as the label is removed to this issue. still is our only AI waiting for to declare metrics as GA ?. looking at it from milestone project 😃

@mateuszrzeszutek
Copy link
Member

Hey @vasireddy99,
That milestone project was about the javaagent GA, we haven't exactly been using it recently, so I just closed it - it was not related to the metrics API/SDK at all, it might've been a bit confusing.
As for the metrics, the Java API & SDK artifacts are stable (the SDK was declared stable recently in v1.14.0); the metrics spec is also stable for the most part, with a couple things that are still being worked on (see https://opentelemetry.io/docs/reference/specification/metrics/sdk/)

@trask
Copy link
Member

trask commented Aug 8, 2022

@trask trask added good first issue Good for newcomers and removed priority:p3 labels Aug 8, 2022
@breedx-splk
Copy link
Contributor

@trask IIRC there are a number of config items that are "composed" (for lack of a better term right now), where the end configs are based on a prefix or something, right? I didn't bother to look for an example, but I swear I've seen that. Won't this miss those?

Not to harsh on the script (it's great!) tho I do think we'd get a lot of mileage out of a more concrete/central config names class or something.

@mateuszrzeszutek
Copy link
Member

@trask IIRC there are a number of config items that are "composed" (for lack of a better term right now), where the end configs are based on a prefix or something, right? I didn't bother to look for an example, but I swear I've seen that. Won't this miss those?

I think that the instrumentation enabled property (otel.instrumentation.<name>.enabled) is probably the only example of this; I think I've removed all other config "templates" when I was working on simplifying/deprecating Config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

7 participants