Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both mongo-3.1 and mongo-3.7 instrumentation have same latestDepTest #1023

Open
anuraaga opened this issue Aug 17, 2020 · 2 comments
Open

Both mongo-3.1 and mongo-3.7 instrumentation have same latestDepTest #1023

anuraaga opened this issue Aug 17, 2020 · 2 comments
Labels
area:build Issues about build infra, both local and central area:tests

Comments

@anuraaga
Copy link
Contributor

When looking at latestDepTest, I noticed that mongo-3.1 and mongo-3.7 both have the same latestDepTest version of +. This is unusual since it means that the old instrumentation works with the newer libraries. From what I can tell, mongo 3.7 instruments a new pattern for building a mongo client. Does it make sense to merge the instrumentation and just test both cases?

@trask
Copy link
Member

trask commented Aug 17, 2020

Changed to required-for-ga with priority p3, to consider it for GA, since it is proposing a change to which instrumentation modules we publish (and I agree the overlap between mongo-3.1 and mongo-3.7 is confusing)

@trask trask removed the area:tests label Aug 17, 2020
@anuraaga
Copy link
Contributor Author

anuraaga commented Aug 18, 2020

couchbase seems to be similar - while latestDepTest isn't exactly the same (spring-data-couchbase version is a bit different, java-client version is same), it seems to have a similar pattern. In fact, 2.6 instrumentation doesn't seem to work without 2.0 instrumentation available which is even more strange and makes merging seem much better.

@iNikem iNikem added area:build Issues about build infra, both local and central area:tests labels Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:build Issues about build infra, both local and central area:tests
Projects
None yet
Development

No branches or pull requests

3 participants