From 3c32c6a8ff00443d2099afd75e054f530b1e84a7 Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Fri, 18 Oct 2024 06:40:24 -0700 Subject: [PATCH] Make Play smoke test work on Java 17 (#12464) --- smoke-tests/images/play/build.gradle.kts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/smoke-tests/images/play/build.gradle.kts b/smoke-tests/images/play/build.gradle.kts index f311ff1b07d6..cd6785505053 100644 --- a/smoke-tests/images/play/build.gradle.kts +++ b/smoke-tests/images/play/build.gradle.kts @@ -6,6 +6,8 @@ plugins { id("otel.spotless-conventions") id("com.google.cloud.tools.jib") + // TODO (trask) this plugin doesn't support Play 2.9+, see https://github.com/gradle/playframework/issues/185 + // once play 3.1 is released, we can update to https://github.com/orgs/playframework/discussions/12338 id("org.gradle.playframework") version "0.14" } @@ -23,6 +25,10 @@ play { dependencies { implementation("com.typesafe.play:play-guice_$scalaVer:$playVer") + // Guice 5.1 is needed for Java 17 support on Play 2.8, see https://github.com/playframework/playframework/releases/tag/2.8.15 + // TODO (trask) remove these version overrides after updating to Play 2.9 + implementation("com.google.inject:guice:5.1.0") + implementation("com.google.inject.extensions:guice-assistedinject:5.1.0") implementation("com.typesafe.play:play-logback_$scalaVer:$playVer") implementation("com.typesafe.play:filters-helpers_$scalaVer:$playVer") }