Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JMX reported metrics #291

Closed
carlosalberto opened this issue Apr 12, 2022 · 5 comments
Closed

Update JMX reported metrics #291

carlosalberto opened this issue Apr 12, 2022 · 5 comments
Assignees
Labels
component: jmx-metrics needs author feedback Waiting for additional feedback from the author Stale type: enhancement New feature or request

Comments

@carlosalberto
Copy link

I've opened a pair of PRs to include the existing JMX metrics for JVM and Kafka Producer/Brokers. I'd love to have the review by the codeowners - specially as I'd like to go over the rest of the metrics, and I don't want that to be a surprise later.

@dehaansa @Mrod1598 @rmfitzpatrick

@dehaansa
Copy link
Contributor

@carlosalberto initially these additions look good, but it may be prudent to wait until the conversations around the long term support for the JMX metrics gatherer are further along (see #282)

@carlosalberto
Copy link
Author

Thanks @dehaansa - I think there's value in defining them anyway, as we will need them one way or another.

Also, it may to your interest specifically that I'd like to (as mentioned in the PR) change some of the metrics from Gauges to UpDownCounters.

(On a related note, FYI, the used/committed/etc memory uses a different set of metrics in the OTel Specs, so I will sending a PR to adjust that in the jmx-metrics subproject.

@carlosalberto
Copy link
Author

@dehaansa You maybe interested in the latest iterations in open-telemetry/opentelemetry-specification#2485 - so far:

  • Most gauges have become UpDownCounters
  • Have left out of the semantic conventions a few metrics that can be synthesized as summary/histogram data points.

@breedx-splk
Copy link
Contributor

Hey @carlosalberto -- this issue has been around for a while, and I think everything that's been linked to has been merged. Is there anything else actionable on this, or can we close it? 🙏🏻 Thanks.

@breedx-splk breedx-splk added the needs author feedback Waiting for additional feedback from the author label Sep 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

This has been automatically marked as stale because it has been marked as needing author feedback and has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@github-actions github-actions bot added the Stale label Oct 4, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: jmx-metrics needs author feedback Waiting for additional feedback from the author Stale type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants