Use Distinct instead of Set for map keys #5027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the last SIG meeting, this is a follow up to #4985. It changes our code to follow out documentation and use the
Distinct
type as a map key.It also clarifies the documentation of the
Set
andDistinct
types. There aren't any plans to change the equivalence ofSet
s the the documentation need to be made explicit to communicate to users the possibility.Optimization of using
Distinct
as a map key are to follow (#5028).